Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for processed files in metro-file-map #1358

Closed
wants to merge 1 commit into from

Conversation

vzaidman
Copy link
Contributor

@vzaidman vzaidman commented Sep 30, 2024

FSREQPROMISE is the garbage collected portion caused by

https://github.com/facebook/metro/blob/main/packages/metro-file-map/src/worker.js#L122

We don't really need to ensure it's destroyed to tell the server is torn down

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2024
@vzaidman vzaidman force-pushed the fix-server-torn-down-using-metro-file-map branch 8 times, most recently from 4d275d2 to 5f8ddbf Compare October 1, 2024 14:26
@facebook-github-bot
Copy link
Contributor

@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@vzaidman vzaidman changed the title [WIP] wait for processed files in metro-file-map Wait for processed files in metro-file-map Oct 1, 2024
@vzaidman vzaidman force-pushed the fix-server-torn-down-using-metro-file-map branch from 5f8ddbf to 0a559e7 Compare October 1, 2024 14:34
@facebook-github-bot
Copy link
Contributor

@vzaidman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@vzaidman merged this pull request in 2817636.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants